Skip to content

fix: use correct boundaries of CSS breakpoints#8520

Open
susnux wants to merge 1 commit intomainfrom
fix/breakpoint
Open

fix: use correct boundaries of CSS breakpoints#8520
susnux wants to merge 1 commit intomainfrom
fix/breakpoint

Conversation

@susnux
Copy link
Copy Markdown
Contributor

@susnux susnux commented May 8, 2026

β˜‘οΈ Resolves

We mixed up breakpoints in the source code, sometimes mobile is max-width 1024, and sometimes width < 1024.
Meaning sometimes mobile is <= 1024 sometimes < 1024.

This now is consistent mobile: width < 1024.

Follow-up on nextcloud/server#57010

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • πŸ“˜ Component documentation has been extended, updated or is not applicable
  • 2️⃣ Backport to stable8 for maintained Vue 2 version or not applicable

We mixed up breakpoints in the source code, sometimes mobile is
`max-width 1024`, and sometimes `width < 1024`.
Meaning sometimes mobile is `<= 1024` sometimes `< 1024`.

This now is consistent `mobile: width < 1024`.

Follow-up on nextcloud/server#57010

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux added this to the 9.8.1 milestone May 8, 2026
@susnux
Copy link
Copy Markdown
Contributor Author

susnux commented May 8, 2026

/backport to stable8

@susnux susnux added bug Something isn't working 3. to review Waiting for reviews and removed backport-request labels May 8, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 8, 2026

Codecov Report

βœ… All modified and coverable lines are covered by tests.
βœ… Project coverage is 54.60%. Comparing base (183d635) to head (aa51f0d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8520   +/-   ##
=======================================
  Coverage   54.60%   54.60%           
=======================================
  Files         106      106           
  Lines        3443     3443           
  Branches     1005     1004    -1     
=======================================
  Hits         1880     1880           
  Misses       1322     1322           
  Partials      241      241           

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

πŸš€ New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • πŸ“¦ JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants